From 3ba7f60fdbd99fb0cef71d01a32388fd231704cc Mon Sep 17 00:00:00 2001 From: Alberto Xamin Date: Wed, 2 Dec 2020 21:56:07 +0100 Subject: [PATCH] fix empty name for lobby --- backend/__init__.py | 6 +++--- frontend/src/components/Lobby.vue | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/backend/__init__.py b/backend/__init__.py index e6a1679..6737c95 100644 --- a/backend/__init__.py +++ b/backend/__init__.py @@ -26,15 +26,15 @@ def advertise_lobbies(): @sio.event def connect(sid, environ): + global online_players + online_players += 1 print('connect ', sid) sio.enter_room(sid, 'lobby') sio.emit('players', room='lobby', data=online_players) @sio.event def set_username(sid, username): - global online_players if not isinstance(sio.get_session(sid), Player): - online_players += 1 sio.save_session(sid, Player(username, sid, sio)) print(f'{sid} is now {username}') advertise_lobbies() @@ -69,8 +69,8 @@ def get_me(sid, room): @sio.event def disconnect(sid): global online_players + online_players -= 1 if sio.get_session(sid): - online_players -= 1 sio.emit('players', room='lobby', data=online_players) if sio.get_session(sid).game and sio.get_session(sid).disconnect(): sio.close_room(sio.get_session(sid).game.name) diff --git a/frontend/src/components/Lobby.vue b/frontend/src/components/Lobby.vue index 34d025b..f0f6ce6 100644 --- a/frontend/src/components/Lobby.vue +++ b/frontend/src/components/Lobby.vue @@ -223,6 +223,8 @@ export default { }, mounted() { console.log('mounted lobby') + if (!this.$route.query.code) + return this.$router.push('/') this.$socket.emit('get_me', {name:this.$route.query.code, password:this.$route.query.pwd}) }, }