From 8734c01843e1ef4a57e01c064dd8719d9accce31 Mon Sep 17 00:00:00 2001
From: Alberto Xamin <alberto@xamin.it>
Date: Mon, 9 Jan 2023 18:00:28 +0000
Subject: [PATCH] improve character visual

---
 backend/bang/characters.py          | 1 +
 backend/server.py                   | 3 ++-
 frontend/src/components/Card.vue    | 2 +-
 frontend/src/components/Chooser.vue | 2 --
 frontend/src/components/Lobby.vue   | 8 +++++++-
 5 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/backend/bang/characters.py b/backend/bang/characters.py
index e327a28..460f996 100644
--- a/backend/bang/characters.py
+++ b/backend/bang/characters.py
@@ -9,6 +9,7 @@ class Character(ABC):
         self.max_lives = max_lives
         self.sight_mod = sight_mod
         self.visibility_mod = visibility_mod
+        self.is_character = True
         self.pick_mod = pick_mod
         self.desc = desc
         self.icon = '🤷‍♂️'
diff --git a/backend/server.py b/backend/server.py
index 23c023e..970d959 100644
--- a/backend/server.py
+++ b/backend/server.py
@@ -208,7 +208,8 @@ def disconnect(sid):
         sio.emit('players', room='lobby', data=online_players)
         if sio.get_session(sid).game and sio.get_session(sid).disconnect():
             sio.close_room(sio.get_session(sid).game.name)
-            games.pop(games.index(sio.get_session(sid).game))
+            if sio.get_session(sid).game in games:
+                games.pop(games.index(sio.get_session(sid).game))
         print('disconnect ', sid)
         advertise_lobbies()
     Metrics.send_metric('online_players', points=[online_players])
diff --git a/frontend/src/components/Card.vue b/frontend/src/components/Card.vue
index f1ef573..552c035 100644
--- a/frontend/src/components/Card.vue
+++ b/frontend/src/components/Card.vue
@@ -177,7 +177,7 @@ export default {
 	left:3pt;
 }
 .card.character .suit {
-	font-size: x-small;
+	font-size: small;
 	right: 3pt;
 	text-align: center;
 }
diff --git a/frontend/src/components/Chooser.vue b/frontend/src/components/Chooser.vue
index 785144c..27dc68c 100644
--- a/frontend/src/components/Chooser.vue
+++ b/frontend/src/components/Chooser.vue
@@ -56,8 +56,6 @@ export default {
 			//console.log(card)
 			if (card.noDesc || card.name == null || card.name == "PewPew!")
 				this.desc = ""
-			else if (card.is_character)
-				this.desc = card.name
 			else if (card.goal)
 				this.desc = this.$t(`cards.${card.name}.name`)
 			else if (card.desc)
diff --git a/frontend/src/components/Lobby.vue b/frontend/src/components/Lobby.vue
index e5b7dd5..f29a790 100644
--- a/frontend/src/components/Lobby.vue
+++ b/frontend/src/components/Lobby.vue
@@ -42,7 +42,7 @@
 				<div v-if="showTurnFlow" id="turn-indicator" :class="{reversed:turnReversed}"/>
 				<transition-group name="list" tag="div" class="players-table">
 					<Card v-if="startGameCard" key="_start_game_" :donotlocalize="true" :card="startGameCard" @click.native="startGame"/>
-					<div v-for="p in playersTable" v-bind:key="p.card.name" style="position:relative;">
+					<div v-for="p in playersTable" v-bind:key="p.card.name" style="position:relative;" class="player-in-table">
 						<transition-group v-if="p.gold_nuggets && p.gold_nuggets > 0" name="list" tag="div" style="position: absolute;top: -10pt; font-size:9pt;">
 							<span v-for="(n, i) in p.gold_nuggets" v-bind:key="i" :alt="i">💵️</span>
 						</transition-group>
@@ -504,5 +504,11 @@ background-position-x: 80px;
 		min-width: 25vw;
 		max-width: 25vw;
 	}
+	.player-in-table {
+		transition: all 0.2s ease-in-out;
+	}
+	.player-in-table:hover {
+		transform: translateY(-5px) scale(1.05);
+	}
 }
 </style>